iP:
Level-5
, A-CodeQuality
, A-AbstractClasses
, A-Packages
tP:
Level-5
, A-CodeQuality
, A-AbstractClasses
, A-Packages
branch-{increment ID}
(e.g. branch-Level-5
). You are recommended to have multiple commits in that branch. Follow the branch naming convention exactly or else our gradings scripts might miss your branch.branch-Level-5
back on to master
, without a fast-forward so that git creates a separate commit for the merge. git tag
that merge commit as Level-5
.Level-5
: Handle Errors Teach Duke to deal with errors such as incorrect inputs entered by the user.
Example:
todo
____________________________________________________________
☹ OOPS!!! The description of a todo cannot be empty.
____________________________________________________________
blah
____________________________________________________________
☹ OOPS!!! I'm sorry, but I don't know what that means :-(
____________________________________________________________
When implementing this feature, you are also recommended to implement the following extension:
A-CodeQuality
: Improve Code Quality Please wait till Mon, Aug 31st to start this task, to give others a few extra days to create the PR if they haven't done so yet.
This task is worth 2x2=4
participtaion points.
Textbook Git & GitHub → Reviewing PRs
The PR review stage is a dialog between the PR author and members of the repo that received the PR, in order to refine and eventually merge the PR.
Given below are some steps you can follow when reviewing a PR.
1. Locate the PR:
2. Read the PR description. It might contain information relevant to reviewing the PR.
3. Click on the Files changed tab to see the diff view.
4. Add review comments:
5. Submit the review:
Overall, I found your code easy to read for the most part except a few places
where the nesting was too deep. I noted a few minor coding standard violations
too. Some of the classes are getting quite long. Consider splitting into smaller
classes if that makes sense.
LGTM
is often used in such overall comments, to indicate Looks good to merge
.nit
is another such term, used to indicate minor flaws e.g., LGTM, almost. Just a few nits to fix.
.Approve
, Comment
, or Request changes
option as appropriate and click on the Submit review button.Step 1 Note these additional guidelines:
Comment
(i.e., not Approve
or Request changes
)Step 2 Do the first PR review as follows.
iP PR review allocation
Tutorial | Reviewer | First PR to review | Backup PR to review |
---|---|---|---|
TIC4001-F18 | JanuariusJang | ZhengShijieNUS | Chilaiping |
TIC4001-F18 | Yiheng0410 | pigoliver | Impala36 |
TIC4001-F18 | Chilaiping | dgc5213 | binbinhui |
TIC4001-F18 | e0260222 | daiweinus | adi-kd0021 |
TIC4001-F18 | Chenduo1412 | e0260222 | daiweinus |
TIC4001-F18 | skyventus | tototto | JanuariusJang |
TIC4001-F18 | Impala36 | e02161618 | Chenduo1412 |
TIC4001-F18 | daiweinus | adi-kd0021 | linqing42 |
TIC4001-F18 | dgc5213 | binbinhui | Yiheng0410 |
TIC4001-F18 | tototto | JanuariusJang | ZhengShijieNUS |
TIC4001-F18 | e02161618 | Chenduo1412 | e0260222 |
TIC4001-F18 | timmyly7 | skyventus | tototto |
TIC4001-F18 | adi-kd0021 | linqing42 | timmyly7 |
TIC4001-F18 | binbinhui | Yiheng0410 | pigoliver |
TIC4001-F18 | linqing42 | timmyly7 | skyventus |
TIC4001-F18 | ZhengShijieNUS | Chilaiping | dgc5213 |
TIC4001-F18 | pigoliver | Impala36 | e02161618 |
If the student you have been allocated to review has not created a PR (or the PR has a trivial amount of code), you can review the Backup PR to review provided in the allocation table. Failing both, pick a PR at random to review.
iP PR review allocation
Tutorial | Reviewer | Second PR to review | Backup PR to review |
---|---|---|---|
TIC4001-F18 | JanuariusJang | dgc5213 | binbinhui |
TIC4001-F18 | Yiheng0410 | e02161618 | Chenduo1412 |
TIC4001-F18 | Chilaiping | Yiheng0410 | pigoliver |
TIC4001-F18 | e0260222 | linqing42 | timmyly7 |
TIC4001-F18 | Chenduo1412 | adi-kd0021 | linqing42 |
TIC4001-F18 | skyventus | ZhengShijieNUS | Chilaiping |
TIC4001-F18 | Impala36 | e0260222 | daiweinus |
TIC4001-F18 | daiweinus | timmyly7 | skyventus |
TIC4001-F18 | dgc5213 | pigoliver | Impala36 |
TIC4001-F18 | tototto | Chilaiping | dgc5213 |
TIC4001-F18 | e02161618 | daiweinus | adi-kd0021 |
TIC4001-F18 | timmyly7 | JanuariusJang | ZhengShijieNUS |
TIC4001-F18 | adi-kd0021 | skyventus | tototto |
TIC4001-F18 | binbinhui | Impala36 | e02161618 |
TIC4001-F18 | linqing42 | tototto | JanuariusJang |
TIC4001-F18 | ZhengShijieNUS | binbinhui | Yiheng0410 |
TIC4001-F18 | pigoliver | Chenduo1412 | e0260222 |
If the allocated PR is not suitable, use the same strategy as before to find an alternative PR to review.
As we are still at the early stages of identifying a problem to solve, do not think of the product (i.e., the solution) yet. That is, do not discuss the product features, UI, command format, and implementation details, etc. unless they are pertinent to the decision of the project direction.
Admin tP: Expectations
project expectations
The high-level learning outcome of the team project (tP):
Accordingly, the tP is structured to resemble an early stage of a small software project in which you will,
The focus of the tP is to learn the following aspects:
You may develop any product provided it is meant for users who can type fast, and prefer typing over mouse/voice commands. Therefore, Command Line Interface (CLI) is the primary mode of input.
Admin tP Contstraints → Constraint-Typing-Preferred
Admin tP Contstraints → Recommendation-CLI-First
Following from the Constraint-Typing-Preferred, if the app is optimized for the target user (graded under the product design criterion), a user who can type fast should be able to accomplish most tasks faster via CLI, compared to a hypothetical GUI-only version of the app. For example, adding a new entity via the CLI should be faster than entering the same data through a GUI form.
Therefore, the input to the app needs to be primarily CLI. If you do implement a GUI, that GUI should primarily be used to give visual feedback to the user. While we don't prohibit non-CLI inputs, note that such inputs will reduce the suitability of the product to target users. Therefore, give CLI alternatives to mouse/GUI inputs, if applicable.
Also keep in mind:
You are strongly discouraged from developing a GUI application as it can increase the workload unnecessarily.
Admin tP Contstraints → Recommendation-No-GUI
Creating a good Java GUI takes a lot of extra effort, which can easily push the tP effort beyond the expected range. In addition, good GUI design is not a learning outcome of this module. Therefore, you are strongly discouraged from creating a GUI application. Choose the GUI path only if you are willing to take the extra workload on top of the module's normal load.
You are expected to:
Why the need to narrow down the user profile?
How narrow can we make the target market?
The size of the target market is not a grading criterion. You can make it as narrow as you want. Even a single user target market is fine as long as you can define that single user in a way others can understand (reason: project evaluators need to evaluate the project from the point of view of the target users).
Example 1: If the product targets TIC4001 instructors, there can be features that are applicable to them only, such as the ability to see a link to a student's project on GitHub
Example 2: If your app manages contacts, you can optimize its features based on,
Your project will be graded based on how well the features match the target user profile and how well the features fit-together.
The expected level of functionality from a team is roughly what you can achieve if each member contributes about the same amount of functional code as required by a i.e., if all requirements were met at the minimal level specifiedtypical iP.
You will get full marks for implementation effort if you meet the expectation stated above. There are no extra marks for exceeding that bar. You are better off spending that effort in improving other aspects of the project.
Tip: Contribute to all aspects of the project e.g. write backend code, frontend code, test code, user documentation, and developer documentation. Reason: If you limit yourself to certain aspects only, you could lose marks allocated for the aspects you did not do. In addition, the final exam assumes that you are familiar with all aspects of the project.
Tip: Do all the work related to your enhancement yourself. Reason: If there is no clear division of who did which enhancement, it will be difficult to divide project credit (or assign responsibility for bugs detected by testers) later.
🤔 How much testings is enough? We expect you to decide. You learned different types of testing and what they try to achieve. Based on that, you should decide how much of each type is required. Similarly, you can decide to what extent you want to automate tests, depending on the benefits and the effort required.
There is no requirement for a minimum coverage level. Note that in a production environment you are often required to have at least 90% of the code covered by tests. In this project, it can be less. The weaker your tests are, the higher the risk of bugs, which will cost marks if not fixed before the final submission.
Team-tasks are the tasks that someone in the team has to do.
Examples of team-tasks
Here is a non-exhaustive list of team-tasks:
Roles indicate aspects you are in charge of and responsible for. E.g., if you are in charge of documentation, you are the person who should allocate which parts of the documentation is to be done by who, ensure the document is in right format, ensure consistency etc.
Recommended roles and responsibilities
This is a non-exhaustive list; you may define additional roles.
Ensure each of the important roles are assigned to one person in the team. It is OK to have a 'backup' for each role, but for each aspect there should be one person who is unequivocally the person responsible for it. Reason: when everyone is responsible for everything, no one is.
Admin tP: Constraints
Your project should comply with the following constraints. Reason: to increase comparability among projects and to maximize applicability of module learning outcomes in the project.
The product should be targeting users who can type fast and prefer typing over other means of input.
Reason: to increase comparability of products, and to make feature evaluation easier for peer evaluators.
The product should be for a single user i.e. (not a multi-user product).
Reason: multi-user systems are hard to test, which is unfair for peer testers who will be graded based on the number of bugs they find.
The product needs to be developed in a breadth-first incremental manner over the project duration. While it is fine to do less in some weeks and more in other weeks, a reasonably consistent delivery rate is expected. For example, it is not acceptable to do the entire project over the recess week and do almost nothing for the remainder of the semester.
Reasons: 1. To simulate a real project where you have to work on a code base over a long period, possibly with breaks in the middle. 2. To learn how to deliver big features in small increments.
The data should be stored locally and should be in a human editable text file.
Reason: To allow advanced users to manipulate the data by editing the data file.
Do not use a Database Management System e.g., MySQLDBMS to store data.
Reason: Using a DBMS to store data will reduce the room to apply OOP techniques to manage data. It is true that most real world systems use a DBMS, but given the small size of this project, we
need to optimize it for TIC4001
module learning outcomes; covering DBMS-related topics will have to be left to database modules or level 3 project modules.
The software should follow the Object-oriented paradigm primarily (but you are allowed to mix in a bit other styles when justifiable).
Reason: For you to practice using OOP in a non-trivial project.
The software should work on the Windows, Linux, and OS-X platforms. Even if you are unable to manually test the app on all three platforms, deliberately avoid using OS-dependent libraries and OS-specific features.
Reason: Peer testers should be able to use any of these platforms.
The software should work on a computer that has version 11 of Java i.e., no other Java version installed.
The software should work without requiring an installer.
Reason: Testers may not want to install your product on their computer.
The software should not depend on your own remote server.
Reason: Anyone should be able to use/test your app any time, even after the semester is over.
The use of third-party frameworks/libraries is allowed but only if they,
and is subjected to prior approval by the teaching team.
Reason: We will not allow third-party software that can interfere with the learning objectives of the module.
Please post in the forum your request to use a third-party libraries before you start using the library. Once a specific library has been approved for one team, other teams may use it without requesting permission again.
Reason: The whole class should know which external software are used by others so that they can do the same if they wish to.
The file sizes of the deliverables should not exceed the limits given below.
JAR file: 100MB (Some third-party software -- e.g., Stanford NLP library, certain graphics libraries -- can cause you to exceed this limit)
PDF files: 15MB/file (Not following the recommended method of converting to PDF format can cause big PDF files. Another cause is using unnecessarily high resolution images for screenshots).
In addition, you are strongly encouraged to follow these recommendations as they can help increase your project score.
It is OK to use a reliable public API e.g., Google search but we recommend that you have a fallback mechanism (e.g., able to load data using a data file if the network is down).
Reason: During the mass peer-testing session, the network access can be intermittent due to high load. If your feature cannot be tested due to lack of Internet, that will have to be counted as a major bug, to be fair to those whose app is being tested and bugs found being penalized.
If you use NUS data (e.g., scrape data from an NUS website), please work with NUS IT directly to get their approval first. Even well-intentioned use of NUS data without approval can get you into serious trouble (has happened before). The teaching team will not be able to get approval for you as the use of NUS data is not a module requirement.
Avoid implementing hard-to-test (both for manual testing as well as automated testing) features or features that make your product hard-to-test.
Reason: testability is a grading criterion. If you choose to implement such a feature, you will need to spend an extra effort to reach an acceptable level of testability.
Here are some examples of features that are hard-to-test:
Creating a good Java GUI takes a lot of extra effort, which can easily push the tP effort beyond the expected range. In addition, good GUI design is not a learning outcome of this module. Therefore, you are strongly discouraged from creating a GUI application. Choose the GUI path only if you are willing to take the extra workload on top of the module's normal load.
Following from the Constraint-Typing-Preferred, if the app is optimized for the target user (graded under the product design criterion), a user who can type fast should be able to accomplish most tasks faster via CLI, compared to a hypothetical GUI-only version of the app. For example, adding a new entity via the CLI should be faster than entering the same data through a GUI form.
Therefore, the input to the app needs to be primarily CLI. If you do implement a GUI, that GUI should primarily be used to give visual feedback to the user. While we don't prohibit non-CLI inputs, note that such inputs will reduce the suitability of the product to target users. Therefore, give CLI alternatives to mouse/GUI inputs, if applicable.
Also keep in mind:
If you are not sure if your product complies with a certain constraint/recommendation, please seek clarification by posting in the forum (preferred) or emailing the supervisor.
Admin tP: Grading → Criteria Used for Grading the Product Design